c# - Error: Object reference not set to an instance of an object./The connection was not closed. The connection's current state is open -

-

for longest time, code has been running, lately encounter error,object reference not set instance of object. don't know if related creation , usage of new database.

here code:

con2.open();     sqlcommand cmd = new sqlcommand();     cmd.connection = con;     cmd.commandtext = "select qtyinhand inventory productid=@productid";     cmd.parameters.add("@productid", sqldbtype.int).value = productid;     int existingqty = (int)cmd.executescalar();     cmd.parameters.clear();     cmd.commandtext = "update inventory set qtyinhand=@qtyinhand productid=@productid";     cmd.parameters.add("@qtyinhand", sqldbtype.int).value = existingqty - int.parse(quantity);     cmd.parameters.add("@productid", sqldbtype.int).value = productid;     cmd.executenonquery();     con2.close();

error on part: int existingqty = (int)cmd.executescalar();

when tried using other sqlconnection: con

con.open();     sqlcommand cmd = new sqlcommand();     cmd.connection = con;     cmd.commandtext = "select qtyinhand inventory productid=@productid";     cmd.parameters.add("@productid", sqldbtype.int).value = productid;     int existingqty = (int)cmd.executescalar();     cmd.parameters.clear();     cmd.commandtext = "update inventory set qtyinhand=@qtyinhand productid=@productid";     cmd.parameters.add("@qtyinhand", sqldbtype.int).value = existingqty - int.parse(quantity);     cmd.parameters.add("@productid", sqldbtype.int).value = productid;     cmd.executenonquery();     con.close();

i encounter error, the connection not closed. connection's current state open. error on con.open(); part. how should solve problem?

for first error, executescalar() call returning null value. either refine query - can check query running directly in database - or change logic deal null values.

for second error, if calling open() throwing error, it's because connection object in use before , not closed properly. it's considered bad practice reuse connections that, consider creating new connection instance when go opening one.

edit: tried imply in second paragraph there, feel must make explicit: don't forget deal connection left open there, may major performance hog application. specially since it's asp.net one. dispose of connections don't need them. when call dispose() connection, gets closed - added bonus of other finer memory management procedures well. read using statement , usage connections have time.


Comments

Post a Comment

Popular posts from this blog

c++ - Linked List error when inserting for the last time -

-
so have part of code here this loop 5 times (max = 5) insert word link list. for ( int = 0 ; < max ; i++ ) { string alphabet = g->returnalphabets(); l[i]->addwords(alphabet[i]); } and have insert word part here string line; fstream myfile ("words.txt"); while (!myfile.eof()) { getline(myfile,line); if ( alphabet == line[0] ) { listnode *newnode = new listnode; if ( head == null ) { newnode->item = alphabet; newnode->next = null; head = newnode; } else { newnode->item = line; prev = cur; prev->next = newnode; } cur = newnode; } } myfile.close(); my problem gives me error on last loop. meaning on max = 4, insert node. rest of loop fine. when decrease max 4 meaning loop 4 times, program error-free when program loops 5 times gives error. anyone can poin...
Read more

java - activate/deactivate sonar maven plugin by profile? -

-
i use sonar plugin executes if activated in maven profile. sonar runs on every compile. the problem build fail other team members not have sonar application installed locally. pom.xml checked in team members same copy including sonar configuration, don't want them modify purpose of disabling sonar (they might inadvertently check modified copy in). please advise how configure maven (.m2/settings.xml) and/or pom.xml sonar feature can enabled/disabled local profile. here sonar configuration in each project's pom.xml: <plugin> <groupid>org.codehaus.mojo</groupid> <artifactid>sonar-maven-plugin</artifactid> <version>1.0</version> <executions> <execution> <id>make-sonar</id> <phase>compile</phase> <goals> <goal>sonar</goal> </goals> </execution> </executions> ...
Read more

tsql - Pivot with Temp Table (definition for column must include data type) -- SQL Server 2008 -

-
the following returning 2 errors: 'the definition column '0.63' must include data type.' 'the select list insert statement contains fewer items insert list. number of select values must match number of insert columns.' i understand need assign data type columns being inserted temp table don't quite understand how dynamic code however. if explanation on how @cols variable code working , specific issue. fldpk data type int , pivot fields i.e. @cols, float data type. declare @cols nvarchar(max), @query nvarchar(max); select @cols = stuff((select distinct ',' + quotename(fldci) fn_qryt_1() xml path(''), type ).value('.', 'nvarchar(max)') ,1,1,'') set @query = 'select fldpk, ' + @cols + ' ( select fldpk ,fldni ...
Read more